Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume plugins dir name to chatrix #205

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Don't assume plugins dir name to chatrix #205

merged 4 commits into from
Mar 24, 2023

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Mar 23, 2023 •
edited by ashfame
Loading

Make it work for when Chatrix is installed under a custom folder like wp-content/my-plugins

  • Improve root_url() to work under any folder

Also fix the relative path shown in site_status_tests

@ashfame ashfame self-requested a review March 23, 2023 17:06
@ashfame ashfame changed the title Improve root_url() to work under any folder Don't assume plugins dir name to chatrix Mar 24, 2023
@ashfame ashfame requested a review from psrpinto March 24, 2023 10:13
@ashfame
Copy link
Member

ashfame commented Mar 24, 2023

Thanks @lezama for the fix! I pushed another related fix within the same PR.

@ashfame ashfame merged commit 28cb1a2 into main Mar 24, 2023
@ashfame ashfame deleted the update/root_url branch March 24, 2023 14:06
@psrpinto psrpinto mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfame ashfame ashfame approved these changes

@psrpinto psrpinto psrpinto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lezama @ashfame @psrpinto